From 3dd6911b58e4ad7bd3f2e019865b15952be2a382 Mon Sep 17 00:00:00 2001 From: Raphael Dannecker Date: Wed, 4 Mar 2026 10:39:07 +0100 Subject: [PATCH 1/2] Add comment line to prevent empty content --- roles/lmn_localhome/tasks/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/roles/lmn_localhome/tasks/main.yml b/roles/lmn_localhome/tasks/main.yml index a06998b..ea3cf2e 100644 --- a/roles/lmn_localhome/tasks/main.yml +++ b/roles/lmn_localhome/tasks/main.yml @@ -33,6 +33,7 @@ dest: /etc/profile.d/lmn-logout.sh mode: '0755' content: | + # logout script (may be empty) {% if localhome_logout_missing_serverhome %} [[ "${UID}" -gt 10000 ]] && ! findmnt /srv/samba/schools/default-school > /dev/null && exit 0 {% endif %} From ec38dcec5eb309912de67091acaf51ded7a1357d Mon Sep 17 00:00:00 2001 From: Daniel Werz Date: Tue, 3 Mar 2026 16:15:03 +0100 Subject: [PATCH 2/2] Fix conditional check of string variable --- roles/lmn_misc/tasks/main.yml | 2 +- roles/lmn_network/tasks/main.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/roles/lmn_misc/tasks/main.yml b/roles/lmn_misc/tasks/main.yml index 23dce2b..cf5a892 100644 --- a/roles/lmn_misc/tasks/main.yml +++ b/roles/lmn_misc/tasks/main.yml @@ -98,7 +98,7 @@ export superusers password_pbkdf2 root {{ grub_pwd }} notify: Run update-grub - when: grub_pwd | bool | default(false) + when: grub_pwd is defined and grub_pwd is truthy - name: Allow booting grub menu entries ansible.builtin.lineinfile: diff --git a/roles/lmn_network/tasks/main.yml b/roles/lmn_network/tasks/main.yml index 571c107..416a173 100644 --- a/roles/lmn_network/tasks/main.yml +++ b/roles/lmn_network/tasks/main.yml @@ -5,14 +5,14 @@ mode: '0644' content: > {{ apt_conf }} - when: apt_conf | bool | default(false) + when: apt_conf is defined and apt_conf is truthy - name: Set NTP server ansible.builtin.lineinfile: path: /etc/systemd/timesyncd.conf insertafter: '^#NTP=' line: NTP={{ ntp_serv }} - when: ntp_serv | bool | default(false) + when: ntp_serv is defined and ntp_serv is truthy - name: Add proposed-updates repository ansible.builtin.apt_repository: