From c3ca8606d6471a571ec26e51b6e809e327c72373 Mon Sep 17 00:00:00 2001
From: "Andreas B. Mundt" <andreas.mundt@steinbeisschule-reutlingen.de>
Date: Tue, 15 Dec 2020 09:55:54 +0100
Subject: [PATCH] Use variables and add mount options for more privacy.

---
 roles/fvs-mkhome/defaults/main.yml |  5 ++++-
 roles/fvs-mkhome/tasks/main.yml    | 14 ++++++++------
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/roles/fvs-mkhome/defaults/main.yml b/roles/fvs-mkhome/defaults/main.yml
index 836e748..26a03ba 100644
--- a/roles/fvs-mkhome/defaults/main.yml
+++ b/roles/fvs-mkhome/defaults/main.yml
@@ -1,2 +1,5 @@
 basedn: "ou=Benutzer,ou=fvs,ou=SCHULEN,o=ml3"
-ldap_server: ldap.steinbeisschule-reutlingen.de
+ldap_server: "ldap.steinbeisschule-reutlingen.de"
+smb_server: "smb.steinbeisschule-reutlingen.de"
+smb_home: "DOCS/fvs/home/"
+smb_share: "DOCS/fvs/tausch/"
diff --git a/roles/fvs-mkhome/tasks/main.yml b/roles/fvs-mkhome/tasks/main.yml
index b83436c..d0bad51 100644
--- a/roles/fvs-mkhome/tasks/main.yml
+++ b/roles/fvs-mkhome/tasks/main.yml
@@ -41,15 +41,17 @@
     block: |
       <volume
         fstype="cifs"
-        server="smb.steinbeisschule-reutlingen.de"
-        path="DOCS/fvs/home/"
-        mountpoint="~/winhome"
+        server="{{ smb_server }}"
+        path="{{ smb_home }}"
+        mountpoint="/media/%(USER)/winhome"
+        options="dir_mode=0750,file_mode=0640"
       />
       <volume
         fstype="cifs"
-        server="smb.steinbeisschule-reutlingen.de"
-        path="DOCS/fvs/tausch/"
-        mountpoint="~/winshare"
+        server="{{ smb_server }}"
+        path="{{ smb_share }}"
+        mountpoint="/media/%(USER)/winshare"
+        options="dir_mode=0750,file_mode=0640"
       />
       <!--volume
         fstype="fuse"